-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add signing certificate to envelope #330
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Maybe add a test to verify it works as expected
+1 for adding a test |
Thanks! I'll work on adding a test tomorrow morning, for now I have been able to "retroactively verify" the v1.1.0 release by manually constructing the correct envelope (inserted certPEM) with the code in: slsa-framework/slsa-verifier#97 now to test e2e and add testing (and remove duped code) |
Added envelope tests! See PR description. |
* add signing certificate to envelope Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali asraa@google.com
Adds a PEM-encoded certificate to the DSSE envelope's signatures. Testing was done to ensure
e2e test using this generator code and my verifier PR: https://github.com/asraa/slsa-on-github-test/actions/runs/2516202385