docs: Update Node.js builder docs #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Also update https://github.com/slsa-framework/slsa-github-generator#builders to say nodejs is now GA
|
We haven't GAed the Node.js builder yet
…On Fri, Aug 4, 2023, 01:44 laurentsimon ***@***.***> wrote:
***@***.**** approved this pull request.
Also update
https://github.com/slsa-framework/slsa-github-generator#builders to say
nodejs is now GA
—
Reply to this email directly, view it on GitHub
<#2282 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMBCJSMHSHNU2ECKJNMETXTPIOVANCNFSM6AAAAAAZFRWHRI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
I thought the release was to GA it... |
This release is to fix some blocking bugs. Specifically #2359 |
Signed-off-by: Ian Lewis <ianlewis@google.com>
d79f512 to
4125e39
Compare
enteraga6
pushed a commit
to enteraga6/slsa-github-generator
that referenced
this pull request
Aug 8, 2023
- Adds a "known issues" section. - Adds instructions on how to custom publish without using the `publish` action. Related slsa-framework#2322 --------- Signed-off-by: Ian Lewis <ianlewis@google.com> Signed-off-by: Noah Elzner <elzner@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publishaction.Related #2322