Make signature level in API optional for signed documents #448
Conversation
| @@ -25,6 +25,7 @@ public void handle(HttpExchange exchange) throws IOException { | |||
| try { | |||
| var body = EndpointUtils.loadFromJsonExchange(exchange, SignRequestBody.class); | |||
| body.validateDocument(); | |||
| body.resolveSigningLevel(); | |||
There was a problem hiding this comment.
nedava zmysel tuto metodu strcit interne do validateSigningParameters? pride mi to taky temporal coupling, ze ked to nezavolas tak sa to nebude spravat dobre.
There was a problem hiding this comment.
na druhej strane, od validate by som čakal, že nebude meniť ten objekt. Ale je pravda, že je to idempotentné, takže by to nemusel byť problém.
There was a problem hiding this comment.
Pravda, najvacsi zmysel by to davalo uplne hore niekde kde sa to body/parametre vyrabaju.
There was a problem hiding this comment.
To áno, ale tieto classy sa vyrábajú trochu magicky cez ten gson parser a nechcel som ísť teraz do toho.
There was a problem hiding this comment.
hej chapem, strcme to do toho validate zatial s nejakou poznamkou
No description provided.