feat: support desctructured properties (#68)

* feat: suppot desctructure properties * feat: support destructured properties --------- Co-authored-by: sloops77 <andres.olave@thinkingbytes.net>
sloops77 · Jun 11, 2024 · e649359 · e649359
1 parent 229e1c7
commit e649359
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/rules/utils/common.js b/rules/utils/common.js
@@ -117,12 +117,12 @@ function getIdentifierDeclaration(identifier, node) {
     const id = _.get('id', n);
     if (_.get('type', id) === 'ObjectPattern') {
       const destructuredProperties = _.get('properties', id) || [];
-      return _.find({value: {name: identifier}}, destructuredProperties);
+      return _.find(prop => prop.value?.name === identifier || (prop.type === 'RestElement' && prop.argument?.name === identifier), destructuredProperties);
     }
 
     if (_.get('type', id) === 'ArrayPattern') {
       const destructuredElements = _.get('elements', id) || [];
-      return _.find({name: identifier}, destructuredElements);
+      return _.find(element => element.name === identifier || (element.type === 'RestElement' && element.argument?.name === identifier), destructuredElements);
     }
 
     return _.get('name', id) === identifier;

diff --git a/test/no-mutating-functions.js b/test/no-mutating-functions.js
@@ -4,7 +4,7 @@ const rule = require('../rules/no-mutating-functions');
 
 const ruleTester = avaRuleTester(test, {
   env: {
-    es6: true,
+    es2020: true,
   },
   parserOptions: {
     sourceType: 'module',

diff --git a/test/no-mutating-methods.js b/test/no-mutating-methods.js
@@ -4,7 +4,7 @@ const rule = require('../rules/no-mutating-methods');
 
 const ruleTester = avaRuleTester(test, {
   env: {
-    es6: true,
+    es2020: true,
   },
   parserOptions: {
     sourceType: 'module',

diff --git a/test/no-mutation.js b/test/no-mutation.js
@@ -4,7 +4,7 @@ const rule = require('../rules/no-mutation');
 
 const ruleTester = avaRuleTester(test, {
   env: {
-    es6: true,
+    es2020: true,
   },
   parserOptions: {
     sourceType: 'module',
@@ -43,7 +43,9 @@ ruleTester.run('no-mutation', rule, {
     'function foo(bar) { let a = bar; if (true) {a = {}}}',
     'function foo(bar) { let a = bar; while (true) { if (true) { a = {} } } }',
     'const a = []; a[0] = 2;',
+    'const [omittedIndex, ...a] = []; a[0] = 2;',
     'const o = {}; o["name"] = 2;',
+    'const {a, b, ...o} = {a: 10, b: 20, c: 30, d: 40, e: 50}; o["b"] = 2;',
     // 'let a = 2; function() { a += 2; }',
     '_.reduce((acc, x) => { acc[2] = 1; return acc; }, [], [1,2,3])',
     '[1,2,3].reduce((acc, x) => { acc += x; return acc; }, 0)',