Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract Editor component into core package #107

Merged
merged 17 commits into from
Nov 6, 2021

Conversation

octokatherine
Copy link
Contributor

closes #100

This PR pulls the UI in the screenshot below into a separate React component inside the core run-wasm package.

A user could import this component from the package to use this default interface. import { Editor } from '@run-wasm/runwasm'

image

@vercel
Copy link

vercel bot commented Oct 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sliphq/run-wasm/28TfVzUmjYNNF4YmCuHNeq9YrC7F
✅ Preview: https://run-wasm-git-fork-octokatherine-package-editor-ui-sliphq.vercel.app

"build": "next build",
"start": "next start",
"lint": "next lint"
"lint": "next lint",
"link-react": "cd ./node_modules/react && yarn link && cd ../../../packages/run-wasm && yarn link \"react\""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're using a local linked module for run-wasm, we have to run this script to tell the run-wasm module to use the example-nextjs project's copy of react. Users using the run-wasm npm package won't have to do this linking because the peer dependency should Just Work.

@kennethcassel
Copy link
Contributor

Great work @octokatherine!

@all-contributors add @octokatherine for her code contributions

@allcontributors
Copy link
Contributor

@kennethcassel

I've put up a pull request to add @octokatherine! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract the <Editor/> component to the core run-wasm package
2 participants