Clear TS output even where there are TS type errors #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sliphq/run-wasm/B8AJfTfKiPUYW1vYCfbzsHVMRejd |
|
yeah this is much more intuitive. Thanks Callum! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102
I think this makes the behaviour a bit more intuitive. This change means that if there is existing output, and then new code is run that has type errors, the result is that we have errors and no output. Previously the existing output would be retained - meaning the errors and outputs came from different code.
Video showing the new behaviour:
Screen.Recording.2021-10-21.at.22.16.55.mov
This PR also adds a call to
npx lerna bootstrapin contributing.md, which is required before callingyarn build.