Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neotoma to extra_applications for elixir 1.15 compatibility #173

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

liamwhite
Copy link
Contributor

Needed to avoid a compilation failure with 1.15

** (UndefinedFunctionError) function :neotoma.file/2 is undefined (module :neotoma is not available)
    (neotoma 1.7.3) :neotoma.file(~c"/tmp/slime/src/slime_parser.peg", [transform_module: :slime_parser_transform])
    tasks/compile.peg.exs:37: Mix.Tasks.Compile.Peg.compile_grammar/2
    (mix 1.15.4) lib/mix/task.ex:447: anonymous fn/3 in Mix.Task.run_task/5
    (mix 1.15.4) lib/mix/tasks/compile.all.ex:124: Mix.Tasks.Compile.All.run_compiler/2
    (mix 1.15.4) lib/mix/tasks/compile.all.ex:104: Mix.Tasks.Compile.All.compile/4
    (mix 1.15.4) lib/mix/tasks/compile.all.ex:93: Mix.Tasks.Compile.All.with_logger_app/2
    (mix 1.15.4) lib/mix/tasks/compile.all.ex:56: Mix.Tasks.Compile.All.run/1
    (mix 1.15.4) lib/mix/task.ex:447: anonymous fn/3 in Mix.Task.run_task/5

@liamwhite liamwhite requested a review from a team as a code owner September 27, 2023 17:41
@joeyates
Copy link

Hi @liamwhite

I'm using your fork with Elixir >= 1.15 and it solves the neotoma missing module problem.

But, I get this warning:

both :extra_applications and :applications was found in your mix.exs. You most likely want to remove the :applications key, as all applications are derived from your dependencies

So, I believe the change should be:

  def application do
    [
-     applications: [:eex]
+     extra_applications: [:eex, :neotoma]
    ]
  end

joeyates added a commit to joeyates/fermo that referenced this pull request Feb 29, 2024
joeyates added a commit to joeyates/fermo that referenced this pull request Feb 29, 2024
@joeyates
Copy link

I would really appreciate if this (or a similar PR) was merged as slime is a dependency of a library that I maintain and I cannot release it (for Elixir >- 1.15) without this change.

Any chance of getting this merged and released?

@liamwhite liamwhite force-pushed the extra-applications-elixir-1.15 branch from cd4ced1 to 4c8ad4e Compare March 4, 2024 20:54
@joeyates
Copy link

joeyates commented Jun 7, 2024

For anyone else who might need Elixir >= 1.15 compatibility, I've released my fork as jgy_slime.

I'll discontinue the fork as/when this gets merged, of course :)

@yordis
Copy link
Member

yordis commented Jun 7, 2024

@joeyates do you mind creating a PR upgrading the package to Elixir >= 1.15

@joeyates
Copy link

joeyates commented Jun 7, 2024

Hi @yordis

I believe this PR has this covered.

@liamwhite 's update to this PR on March 4th uses :extra_applications exclusively, which I think is the correct approach.

@yordis yordis merged commit 8cca16d into slime-lang:master Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants