Only regenerate parser if grammar has changed #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `slime_parser.erl` was regenerated on each compilation, which casued any file depending on it to be recompiled, even if nothing changed. This continues to generate the grammar each time, but if it doesn't differ from what's on disk, skip regenerating the parser.
doomspork
reviewed
Oct 30, 2019
There was a problem hiding this comment.
Welcome @sionide21! This looks good to me. @Rakoth do you have any thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
slime_parser.erlwas regenerated on each compilation,which casued any file depending on it to be recompiled, even if nothing
changed.
This continues to generate the grammar each time, but if it doesn't
differ from what's on disk, skip regenerating the parser.