Skip to content

Commit

Permalink
Gizmos updates v1 (fast forwarding from v2) (playcanvas#6996)
Browse files Browse the repository at this point in the history
* ff gizmos in v1 to match v2

* added new files

* updated all @import to typedef
  • Loading branch information
kpal81xd authored Sep 30, 2024
1 parent d7b902d commit 21693b0
Show file tree
Hide file tree
Showing 19 changed files with 1,678 additions and 1,065 deletions.
15 changes: 2 additions & 13 deletions examples/src/examples/misc/gizmos.example.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -137,19 +137,8 @@ light.addComponent('light', {
app.root.addChild(light);
light.setEulerAngles(0, 0, -60);

// create layers
const gizmoLayer = new pc.Layer({
name: 'Gizmo',
clearDepthBuffer: true,
opaqueSortMode: pc.SORTMODE_NONE,
transparentSortMode: pc.SORTMODE_NONE
});
const layers = app.scene.layers;
layers.push(gizmoLayer);
camera.camera.layers = camera.camera.layers.concat(gizmoLayer.id);

// create gizmo
const gizmoHandler = new GizmoHandler(app, camera.camera, gizmoLayer);
const gizmoHandler = new GizmoHandler(app, camera.camera);
gizmoHandler.switch('translate');
gizmoHandler.add(box);
window.focus();
Expand Down Expand Up @@ -257,7 +246,7 @@ data.on('*:set', (/** @type {string} */ path, value) => {

// picker
const picker = new pc.Picker(app, canvas.clientWidth, canvas.clientHeight);
const worldLayer = layers.getLayerByName('World');
const worldLayer = app.scene.layers.getLayerByName('World');
const pickerLayers = [worldLayer];

const onPointerDown = (/** @type {PointerEvent} */ e) => {
Expand Down
10 changes: 5 additions & 5 deletions examples/src/examples/misc/gizmos.gizmo-handler.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ class GizmoHandler {
/**
* @param {pc.AppBase} app - The application.
* @param {pc.CameraComponent} camera - The camera component.
* @param {pc.Layer} layer - The gizmo layer
*/
constructor(app, camera, layer) {
constructor(app, camera) {
const layer = pc.Gizmo.createLayer(app);
this._gizmos = {
translate: new pc.TranslateGizmo(app, camera, layer),
rotate: new pc.RotateGizmo(app, camera, layer),
scale: new pc.ScaleGizmo(app, camera, layer)
translate: new pc.TranslateGizmo(camera, layer),
rotate: new pc.RotateGizmo(camera, layer),
scale: new pc.ScaleGizmo(camera, layer)
};

for (const type in this._gizmos) {
Expand Down
Loading

0 comments on commit 21693b0

Please sign in to comment.