Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce babel support #791

Closed
wants to merge 2 commits into from
Closed

Introduce babel support #791

wants to merge 2 commits into from

Conversation

bary822
Copy link

@bary822 bary822 commented Nov 24, 2017

Since Tilt already supports babel, it would be great if slim users are able to write their ES6 code in slim template as inline.

This should suffice #699.

@bary822 bary822 force-pushed the introduce_babel_inline_support branch from 8814172 to ee07fd8 Compare November 24, 2017 10:01
@bary822
Copy link
Author

bary822 commented Nov 28, 2017 •
edited
Loading

As for the failure on CI with bundler(NameError: Missing or uninitialized constant: Bundler::Deprecate) in rbx-3.86, we need to wait for this to be fixed, or specify lower version so it should work correctly.

@bary822 bary822 force-pushed the introduce_babel_inline_support branch 2 times, most recently from 65938ab to f25ffe3 Compare November 28, 2017 02:50
@minad minad mentioned this pull request May 5, 2018
Closed
minad
minad reviewed May 5, 2018
View reviewed changes
lib/slim/embedded.rb
@@ -132,7 +132,16 @@ def collect_newlines(body)
# Basic tilt engine
class TiltEngine < Engine
def on_slim_embedded(engine, body)
tilt_engine = Tilt[engine] || raise(Temple::FilterError, "Tilt engine #{engine} is not available.")
begin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this specific error message

Copy link
Author

@bary822 bary822 May 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you meant to mention line 139, I can be convinced to remove it.

However, on the other hand, it's true that Tilt with version 2.0.1 or earlier does not support babel-transpiler which causes failures on some travis matrix.

Could you share the background why we are testing against various version of Tilt gem? So we can come up with appropriate error message, or alternative solution to handle it. Thanks.

@stonean stonean mentioned this pull request Jul 14, 2018
Closed
@kuba-machacek
Copy link

If I undestand it correctly then Tilt depends on babel-transpiler (https://github.com/babel/ruby-babel-transpiler) which is abandoned and depends on babel-source (https://rubygems.org/gems/babel-source/) which does not support Babel above 5.8.35 (January 2016).

@brauliobo
Copy link

@kuba-machacek sad news...
@bary822 I'll test your branch soon

@bary822
Copy link
Author

bary822 commented Oct 9, 2018

@brauliobo
I'm sorry that I kept this alone for a long time. I hope I'll soon get a chance to check the issue @kuba-machacek described above.

@minad
Copy link
Member

minad commented Dec 31, 2022

Is there still interest in this PR? If yes, please update!

@minad minad closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minad minad minad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bary822 @kuba-machacek @brauliobo @minad @dapi