Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-vitess-r14.0.5:cherrypick-fix panic in vtgate when MakeRowTrusted got wrong result #78

Merged
merged 1 commit into from
May 9, 2023
Merged

slack-vitess-r14.0.5:cherrypick-fix panic in vtgate when MakeRowTrusted got wrong result #78

merged 1 commit into from
May 9, 2023

Conversation

tanjinx
Copy link

@tanjinx tanjinx commented May 9, 2023 •
edited
Loading

Description

similar as #21

  851  wget https://github.com/slackhq/vitess/pull/21.patch
  860  git apply -v ~/21.patch

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@tanjinx tanjinx requested a review from a team as a code owner May 9, 2023 03:44
vmogilev
vmogilev requested changes May 9, 2023
View reviewed changes
Copy link

@vmogilev vmogilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible, can you please share the commands you used to pull these cherry picks into slack-cherrypick-makerowtrusted?

vmogilev
vmogilev approved these changes May 9, 2023
View reviewed changes
Copy link

@vmogilev vmogilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@tanjinx tanjinx merged commit 3cfa60f into slack-vitess-r14.0.5 May 9, 2023
@tanjinx tanjinx changed the title slack-vitess-r14.0.5:cherrypick-fix panic in vtgate slack-vitess-r14.0.5:cherrypick-fix panic in vtgate when MakeRowTrusted got wrong result May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmogilev vmogilev vmogilev approved these changes

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt

Assignees
No one assigned
Labels
slack-cherrypick upstream-backport An upstream backport v14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanjinx @vmogilev