Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-19.0: Add GetServerStatus RPC to use in PRS (#16022) #607

Merged
merged 1 commit into from
Feb 18, 2025
Merged

slack-19.0: Add GetServerStatus RPC to use in PRS (#16022) #607

merged 1 commit into from
Feb 18, 2025

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Feb 17, 2025 •
edited
Loading

Description

The PR backports vitessio#16022 (v20 PR) to slack-19.0 in order to resolve this error with slack-21.0 upgrade/downgrade testing slack-19.0:

rpc error: code = Unimplemented desc = unknown method GetGlobalStatusVars for service tabletmanagerservice.TabletManager

vitessio#16022 only adds the new RPC and doesn't use it, so this PR should have no impact to slack-19.0

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100 @timvaillancourt
Add GetServerStatus RPC to use in PRS (vitessio#16022)
5e8cfa5 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@salesforce-cla Salesforce CLA
Copy link

Thanks for the contribution! Before we can merge this, we need @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement.

@github-actions github-actions bot added this to the v19.0.7 milestone Feb 17, 2025
@timvaillancourt timvaillancourt marked this pull request as ready for review February 17, 2025 22:03
@timvaillancourt timvaillancourt requested a review from a team as a code owner February 17, 2025 22:03
tanjinx
tanjinx requested changes Feb 18, 2025
View reviewed changes
Copy link

@tanjinx tanjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should merge this into the prod-release branch as v19 is being rolled out in prod.

@timvaillancourt timvaillancourt merged commit 1c36ad8 into slack-19.0 Feb 18, 2025
169 of 172 checks passed
@timvaillancourt timvaillancourt deleted the bp-pr16022.slack-19.0 branch February 18, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjinx tanjinx tanjinx approved these changes

Assignees
No one assigned
Labels
cla:missing upstream-backport An upstream backport v20-backport
Projects
None yet
Milestone
v19.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@timvaillancourt @tanjinx @GuptaManan100