apply patch 12623 #132
Merged
apply patch 12623 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
timvaillancourt
pushed a commit
that referenced
this pull request
May 27, 2024
* apply patch 12623 Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * fix unit test Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * revert regex Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * update regex Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
timvaillancourt
pushed a commit
that referenced
this pull request
May 29, 2024
* apply patch 12623 Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * fix unit test Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * revert regex Signed-off-by: Priya Bibra <pbibra@slack-corp.com> * update regex Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch 12623: vitessio#12623
Note:
The regex in this PR is different from the one in the patch. The original author notes that there was a test failure with their regex change possibly which is the same test failure we hit here earlier. I'll put in a request upstream to make the same change, but I think this regex covers more cases.