improve comment

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
slackhq · May 20, 2024 · a3b2660 · a3b2660
1 parent 9f54ac2
commit a3b2660
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/upgrade_downgrade_test_reparent_old_vtctl.yml b/.github/workflows/upgrade_downgrade_test_reparent_old_vtctl.yml
@@ -191,5 +191,8 @@ jobs:
           mkdir -p /tmp/vtdataroot
 
           source build.env
-          export SKIPTESTCROSSCELLDURABILITY=1 # skip on v14
+
+          # skip TestCrossCellDurability test on v14 (as previous). It doesn't setup semi-sync the way this test (from v16) expects
+          export SKIPTESTCROSSCELLDURABILITY=1
+
           eatmydata -- go run test.go -skip-build -keep-data=false -docker=false -print-log -follow -tag upgrade_downgrade_reparent
diff --git a/.github/workflows/upgrade_downgrade_test_reparent_old_vttablet.yml b/.github/workflows/upgrade_downgrade_test_reparent_old_vttablet.yml
@@ -188,5 +188,8 @@ jobs:
           mkdir -p /tmp/vtdataroot
 
           source build.env
-          export SKIPTESTCROSSCELLDURABILITY=1 # skip on v14
+
+          # skip TestCrossCellDurability test on v14 (as previous). It doesn't setup semi-sync the way this test (from v16) expects
+          export SKIPTESTCROSSCELLDURABILITY=1
+
           eatmydata -- go run test.go -skip-build -keep-data=false -docker=false -print-log -follow -tag upgrade_downgrade_reparent