Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Carthage compatibility #294

Merged
merged 1 commit into from
Oct 26, 2015
Merged

Carthage compatibility #294

merged 1 commit into from
Oct 26, 2015

Conversation

AndrewSB
Copy link
Contributor

Tried to include SlackTextViewController in my project through Carthage, was told

*** Skipped building SlackTextViewController due to the error:
Dependency "SlackTextViewController" has no shared framework schemes

If you believe this to be an error, please file an issue with the maintainers at https://github.com/slackhq/SlackTextViewController/issues/new

Seems to be that you aren't sharing the framework scheme, I added that. If this is merged and a new tagged release is created (current latest is v1.7.1) I believe Carthage will be able to build SlackTextViewController

@AndrewSB
Copy link
Contributor Author

Yup, this works. Just tested by using my fork in the Cartfile

dzenbot pushed a commit that referenced this pull request Oct 26, 2015
@dzenbot dzenbot merged commit 068a61b into slackhq:master Oct 26, 2015
@dzenbot
Copy link

dzenbot commented Oct 26, 2015

Thanks 👍

@AndrewSB
Copy link
Contributor Author

AndrewSB commented Nov 2, 2015

@dzenbot any chance you can also create a new tagged release? Carthage takes the latest one and so far it's Checking out SlackTextViewController at "v1.7.1", not pulling in my changes unless I explicitly specify the commit hash

@dzenbot
Copy link

dzenbot commented Nov 2, 2015

Will do, tomorrow morning 😉

@AndrewSB
Copy link
Contributor Author

AndrewSB commented Nov 2, 2015

thanks 😄

@dzenbot
Copy link

dzenbot commented Nov 4, 2015

1.7.2 is out!

@AndrewSB
Copy link
Contributor Author

AndrewSB commented Nov 4, 2015

awesome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants