Add didTransition in PanModalPresentable delegate

slackhq · Oct 31, 2022 · a75b607 · a75b607
1 parent 0ba076e
commit a75b607
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/PanModal/Controller/PanModalPresentationController.swift b/PanModal/Controller/PanModalPresentationController.swift
@@ -259,11 +259,15 @@ public extension PanModalPresentationController {
 
         presentable?.willTransition(to: state)
 
+        let completion: () -> Void = { [weak self] in
+            self?.presentable?.didTransition(to: state)
+        }
+
         switch state {
         case .shortForm:
-            snap(toYPosition: shortFormYPosition)
+            snap(toYPosition: shortFormYPosition, completion: completion)
         case .longForm:
-            snap(toYPosition: longFormYPosition)
+            snap(toYPosition: longFormYPosition, completion: completion)
         }
     }
 
@@ -643,12 +647,15 @@ private extension PanModalPresentationController {
         return (abs(velocity) - (1000 * (1 - Constants.snapMovementSensitivity))) > 0
     }
 
-    func snap(toYPosition yPos: CGFloat) {
+    func snap(toYPosition yPos: CGFloat, completion: (() -> Void)? = nil) {
         PanModalAnimator.animate({ [weak self] in
             self?.adjust(toYPosition: yPos)
             self?.isPresentedViewAnimating = true
         }, config: presentable) { [weak self] didComplete in
             self?.isPresentedViewAnimating = !didComplete
+            if didComplete {
+                completion?()
+            }
         }
     }
 

diff --git a/PanModal/Presentable/PanModalPresentable+Defaults.swift b/PanModal/Presentable/PanModalPresentable+Defaults.swift
@@ -117,6 +117,10 @@ public extension PanModalPresentable where Self: UIViewController {
 
     }
 
+    func didTransition(to state: PanModalPresentationController.PresentationState) {
+
+    }
+
     func panModalWillDismiss() {
 
     }

diff --git a/PanModal/Presentable/PanModalPresentable.swift b/PanModal/Presentable/PanModalPresentable.swift
@@ -220,6 +220,13 @@ public protocol PanModalPresentable: AnyObject {
      */
     func willTransition(to state: PanModalPresentationController.PresentationState)
 
+    /**
+     Notifies the delegate that the pan modal transitioned to a new state.
+
+     Default value is an empty implementation.
+     */
+    func didTransition(to state: PanModalPresentationController.PresentationState)
+
     /**
      Notifies the delegate that the pan modal is about to be dismissed.
-Original file line number
+Diff line change
@@ Expand Up @@
         }
+        func didTransition(to state: PanModalPresentationController.PresentationState) {
+        }
         func panModalWillDismiss() {
         }
@@ Expand Down @@