Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable tests that are now stable #1617

Merged
merged 1 commit into from
Dec 17, 2024
Merged

build: enable tests that are now stable #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:
- "pypy3.10"
env:
CI_LARGE_SOCKET_MODE_PAYLOAD_TESTING_DISABLED: "1"
CI_UNSTABLE_TESTS_SKIP_ENABLED: "1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 😌 🎉

FORCE_COLOR: "1"
steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 0 additions & 4 deletions tests/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,3 @@ def remove_os_env_temporarily() -> dict:

def restore_os_env(old_env: dict) -> None:
os.environ.update(old_env)


def is_ci_unstable_test_skip_enabled() -> bool:
return os.environ.get("CI_UNSTABLE_TESTS_SKIP_ENABLED") == "1"
5 changes: 0 additions & 5 deletions tests/slack_sdk/socket_mode/test_interactions_websocket_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

from slack_sdk import WebClient
from slack_sdk.socket_mode.websocket_client import SocketModeClient
from tests.helpers import is_ci_unstable_test_skip_enabled
from tests.slack_sdk.socket_mode.mock_socket_mode_server import (
start_socket_mode_server,
socket_mode_envelopes,
Expand Down Expand Up @@ -90,10 +89,6 @@ def socket_mode_request_handler(client: BaseSocketModeClient, request: SocketMod
client.close()

def test_send_message_while_disconnection(self):
if is_ci_unstable_test_skip_enabled():
# this test tends to fail on the GitHub Actions platform
return

try:
client = SocketModeClient(
app_token="xapp-A111-222-xyz",
Expand Down
Loading