preventing double slash in the api_url #1596
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses issue #1595 by ensuring that URLs generated for Slack API requests are correctly formatted to prevent double slashes (
//
) cause by the previous PR #1594 . The issue occurs when thebase_url
ends with a trailing slash (/
) and theapi_method
starts with a leading slash (/
). This PR modifies the_get_url
function to handle such cases by trimming the trailing slash from thebase_url
when necessary.Testing
Run either
./scripts/run_validation.sh
or./scripts/run_unit_tests.sh tests/web/test_web_client.py
Category
/docs
(Documents)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.