Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update release instructions in maintainers guide #1507

Merged

Conversation

WilliamBergamin
Copy link
Contributor

Summary

Fix release instructions in maintainers_guide.md

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs-src (Documents, have you run ./scripts/docs.sh?)
  • /docs-src-v2 (Documents, have you run ./scripts/docs-v2.sh?)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@WilliamBergamin WilliamBergamin added the docs M-T: Documentation work only label Jun 10, 2024
@WilliamBergamin WilliamBergamin requested a review from seratch June 10, 2024 20:15
@WilliamBergamin WilliamBergamin self-assigned this Jun 10, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (41cbaa4) to head (55535bb).

Current head 55535bb differs from pull request most recent head 1c7e41a

Please upload reports for the commit 1c7e41a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
- Coverage   85.08%   85.06%   -0.03%     
==========================================
  Files         112      112              
  Lines       12320    12320              
==========================================
- Hits        10483    10480       -3     
- Misses       1837     1840       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. Could you add one more addition? Closing the GitHub milestone for the release is missing in the document. When making a new release, its GH milestone needs to be closed as well (I did for you this time: https://github.com/slackapi/python-slack-sdk/milestones?state=closed)

@seratch
Copy link
Member

seratch commented Jun 11, 2024

Also, creating the next patch version is preferred. I mean I've closed 3.28.0 and created 3.28.1 for forthcoming issues and PRs.

@WilliamBergamin WilliamBergamin added this to the 2.28.1 milestone Jun 11, 2024
@WilliamBergamin WilliamBergamin merged commit 862796c into slackapi:main Jun 12, 2024
10 checks passed
@WilliamBergamin WilliamBergamin deleted the update-maintainers-guide branch June 12, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants