You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have been using this SDK with a uvicorn server. They have recently upgraded the websockets requirements (link), and the version 9.1 includes a fix for a security issue introduced in version 8.
Currently, they require >=9.1, while this SDK requires >=8,<9. It would be awesome if you could also bump your requirements so that we didn't need to pin the uvicorn version and could also benefit from this security fix.
I'd be happy to open a PR to help with the upgrade if needed, but I couldn't quite figure out how the library is used and what code changes might need to be done for this major upgrade.
Category (place an x in each of the [ ])
slack_sdk.web.WebClient (sync/async) (Web API client)
Hi @ggml1, thanks for sharing this! There is no blocker for upgrading websockets dependency to the latest as it's an optional one. As this is a security update, we set 9.1 as the oldest supported version. I think we can set >=9.1,<10 this time. Your contributions would be appreciated!
ggml1
added a commit
to ggml1/python-slack-sdk
that referenced
this issue
Jun 4, 2021
Hey!
I have been using this SDK with a uvicorn server. They have recently upgraded the websockets requirements (link), and the version 9.1 includes a fix for a security issue introduced in version 8.
Currently, they require
>=9.1
, while this SDK requires>=8,<9
. It would be awesome if you could also bump your requirements so that we didn't need to pin the uvicorn version and could also benefit from this security fix.I'd be happy to open a PR to help with the upgrade if needed, but I couldn't quite figure out how the library is used and what code changes might need to be done for this major upgrade.
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
The text was updated successfully, but these errors were encountered: