Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows WebClient token to be undefined #499

Merged
merged 7 commits into from
Mar 14, 2018

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Mar 14, 2018

Summary

this PR also introduces a new set of integration tests that are useful for running the typescript compiler as if a consumer of this package were to using it.

fixes #482

Requirements (place an x in each [ ])

@aoberoi aoberoi force-pushed the webclient-no-token branch from f07f8f0 to 9d0801c Compare March 14, 2018 18:26
@codecov
Copy link

codecov bot commented Mar 14, 2018

Codecov Report

Merging #499 into master will increase coverage by 1.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   80.08%   81.32%   +1.24%     
==========================================
  Files           6        6              
  Lines         241      241              
  Branches       37       37              
==========================================
+ Hits          193      196       +3     
+ Misses         30       29       -1     
+ Partials       18       16       -2
Impacted Files Coverage Δ
src/WebClient.ts 80.91% <ø> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c49ba78...9d0801c. Read the comment docs.

@aoberoi aoberoi merged commit 805dd6f into slackapi:master Mar 14, 2018
@aoberoi aoberoi deleted the webclient-no-token branch March 14, 2018 18:29
@aoberoi aoberoi mentioned this pull request Mar 14, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebClient constructor should allow no token
2 participants