-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally allow a user ID to be passed into users.identity for WTA #432
Conversation
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 89.01% 89.03% +0.01%
==========================================
Files 44 44
Lines 1247 1249 +2
Branches 187 189 +2
==========================================
+ Hits 1110 1112 +2
Misses 137 137
Continue to review full report at Codecov.
|
@bertrandom this is great! i have a couple questions for ya.
|
Update: i'm dumb.
we actually want to support these call sites then:
|
@aoberoi Let me try to get that parameter unhidden before we change this. And you make a good point, using options instead of user will help us future-proof if we add more params later, I'll update the PR. |
@aoberoi Okay, I modified this to pass an options object, would you mind reviewing it one last time and then merging it in when you get a chance? Thanks. |
thanks so much @bertrandom! |
Summary
users.identity can now be passed a user ID when used with Workspace Token Apps. This allows an optional user ID to be passed into the method, while supporting the old function signature where this parameter used to be a callback.
Requirements (place an
x
in each[ ]
)