-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we reconnect with the same options passed to start #347
Conversation
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 85.8% 85.99% +0.18%
==========================================
Files 44 44
Lines 1205 1207 +2
Branches 178 178
==========================================
+ Hits 1034 1038 +4
+ Misses 171 169 -2
Continue to review full report at Codecov.
|
@@ -175,7 +181,7 @@ RTMClient.prototype._lastPong = 0; | |||
|
|||
|
|||
/** | |||
* | |||
* A running count of socket connection attempts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are a saint for fixing things like this 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i gotchu dawg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome!
PR Summary
Related Issues
Test strategy