Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tsconfig skiplibcheck:true - dont typecheck dependency d.ts files #1913

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Sep 3, 2024

Should unblock #1912

@filmaj filmaj added semver:patch tests M-T: Testing work only area:typescript issues that specifically impact using the package from typescript projects labels Sep 3, 2024
@filmaj filmaj requested a review from a team September 3, 2024 15:52
@filmaj filmaj self-assigned this Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (220da72) to head (399676a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1913   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files          34       34           
  Lines        7666     7666           
  Branches      381      381           
=======================================
  Hits         6920     6920           
  Misses        734      734           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 94.94% <ø> (ø)
cli-test 96.93% <ø> (ø)
oauth 76.53% <ø> (ø)
socket-mode 59.59% <ø> (ø)
web-api 96.57% <ø> (ø)
webhook 95.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@filmaj filmaj merged commit 7bf89e6 into main Sep 3, 2024
30 checks passed
@filmaj filmaj deleted the tsconfig-skip-libcheck branch September 3, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typescript issues that specifically impact using the package from typescript projects semver:patch tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant