Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module.exports.repository.replace is not a function #303

Closed
3 tasks done
rauno56 opened this issue Dec 20, 2016 · 4 comments
Closed
3 tasks done

module.exports.repository.replace is not a function #303

rauno56 opened this issue Dec 20, 2016 · 4 comments
Assignees
@UncannyBingo
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented

Comments

@rauno56
Copy link

rauno56 commented Dec 20, 2016

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

When I do:

npm install @slack/client
node -e 'require("@slack/client")'

The output I get is this:

TypeError: module.exports.repository.replace is not a function

It's because on the installed version the value of repository property in package.json is:

{ type: 'git',
  url: 'git+https://github.com/slackapi/node-slack-sdk.git' }

Which, I guess, is not expected.

On linux. Latest version.
@palmerabollo
Copy link

palmerabollo commented Dec 20, 2016 •
edited
Loading

Same here. The module is broken now.

@UncannyBingo
Copy link

Right. I did not expect that NPM would actually alter the package.json file. TIL. Getting a fix out now.

@UncannyBingo UncannyBingo self-assigned this Dec 20, 2016
@UncannyBingo UncannyBingo added the bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented label Dec 20, 2016
palmerabollo referenced this issue Dec 20, 2016
Telemetry (#302)
507f9b0 
* First commit

* Get the actual package name and version

* passing tests and linter

* Expose the version string as the user agent for WebAPI calls

* Use GH repo name instead of node module name

* Oh, linters

* Add OS and node version to user agent

* Add user agent to all outbound events

* Fix a few bugs here and there.

* Saner linting rules

* We don't need that anymore, apparently.

* Add user agent to outbound WS connections. Just in case.

* Remove ability to override user agent

* That was a not very good interface, let's remove it.

* Allow users to make mistakes

* One more test

* Make it better again

* JSDocs, yeah!
UncannyBingo pushed a commit that referenced this issue Dec 21, 2016
Fix #303
3810c34
@UncannyBingo UncannyBingo mentioned this issue Dec 21, 2016
Merged
UncannyBingo pushed a commit that referenced this issue Dec 21, 2016
Fix #303
2a40505
UncannyBingo pushed a commit that referenced this issue Dec 21, 2016
Fix #303 (#304)
4169978
@UncannyBingo
Copy link

@rauno56 @palmerabollo Can you confirm the issue is resolved?

@palmerabollo
Copy link

It works now. Thank you @DEGoodmanWilson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UncannyBingo UncannyBingo

Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@UncannyBingo @palmerabollo @rauno56