Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 512 - Fixed SPM file scope/path issues #517

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Issue 512 - Fixed SPM file scope/path issues #517

merged 1 commit into from
Oct 26, 2020

Conversation

noorulain17
Copy link
Collaborator

@noorulain17 noorulain17 commented Oct 25, 2020 •
edited
Loading

Fixed #512

  • Fixed SPM file scope/path issues
  • Added SPM screenshot
  • Deleted unused project files

Moved Pickers folder inside CoreActionSheetPicker path
Screenshot 2020-10-25 at 5 45 00 PM

@noorulain17 noorulain17 requested a review from skywinder October 25, 2020 13:45
@noorulain17 noorulain17 mentioned this pull request Oct 25, 2020
Closed
@noorulain17 noorulain17 self-assigned this Oct 25, 2020
@noorulain17 noorulain17 changed the title Issue 512: Fixed SPM file scope/path issues Issue 512 - Fixed SPM file scope/path issues Oct 25, 2020
@noorulain17 noorulain17 force-pushed the swift-package_manager_ branch from 6f35d14 to 36a2731 Compare October 25, 2020 16:57
- Fixed SPM file scope/path issues
0028583 
- Added SPM screenshot

- Deleted unused project files
@noorulain17 noorulain17 force-pushed the swift-package_manager_ branch from 36a2731 to 0028583 Compare October 25, 2020 17:16
skywinder
skywinder approved these changes Oct 26, 2020
View reviewed changes
Copy link
Owner

@skywinder skywinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks for the fix!

@skywinder skywinder merged commit ebdfd69 into develop Oct 26, 2020
@noorulain17 noorulain17 deleted the swift-package_manager_ branch October 26, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skywinder skywinder skywinder approved these changes

@KunzManuel KunzManuel Awaiting requested review from KunzManuel

Assignees

@noorulain17 noorulain17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPM: Cannot find type 'ActionSheetStringPicker' in scope
2 participants
@noorulain17 @skywinder