Supported interface orientations fix #399
Conversation
Pickers/SWActionSheet.m
Outdated
| @@ -91,7 +92,9 @@ - (UIWindow *)window | |||
| UIWindow *window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds]; | |||
| window.windowLevel = self.windowLevel; | |||
| window.backgroundColor = [UIColor clearColor]; | |||
| window.rootViewController = [SWActionSheetVC new]; | |||
| SWActionSheetVC *new = [SWActionSheetVC new]; | |||
There was a problem hiding this comment.
new is reserved name, sot lets use more related to this class name.
| @@ -502,6 +506,7 @@ | |||
| ALWAYS_SEARCH_USER_PATHS = NO; | |||
| CLANG_ENABLE_OBJC_ARC = YES; | |||
| COPY_PHASE_STRIP = YES; | |||
| DEVELOPMENT_TEAM = M8UU7YPNPZ; | |||
There was a problem hiding this comment.
please remove dev team from this PR
| - (BOOL)shouldAutorotate | ||
| { | ||
| return YES; | ||
| if (self.maskVC == UIInterfaceOrientationPortrait){ |
There was a problem hiding this comment.
What do you mean? Can you please elaborate or suggest a better approach?
There was a problem hiding this comment.
Here is is:
return (!self.maskVC == UIInterfaceOrientationPortrait);
:)
There was a problem hiding this comment.
Please, put it this way, so it makes the style more readable. it's just about good code style
|
Hey can you please revisit? |
|
Dear @moheny , thank you very much for the stay in touch. Cheers 👍 |
|
Looks good, when is this expected to be merged ? |
|
@skywinder is this going to be merged anytime soon? Thanks |
|
Hello everyone! Thank you for your patience! I'm back and will cleanup everything. Thank you very much for your contribution! |
| @@ -13,7 +13,9 @@ | |||
|
|
|||
| - (void)showFromBarButtonItem:(UIBarButtonItem *)item animated:(BOOL)animated; | |||
|
|
|||
| - (instancetype)initWithView:(UIView *)view windowLevel:(UIWindowLevel)windowLevel; | |||
| - (instancetype)initWithView:(UIView *)view windowLevel:(UIWindowLevel)windowLevel withSupportedOrientation:(UIInterfaceOrientationMask) mask; | |||
There was a problem hiding this comment.
please, do not change already existing init methind, otherwise we are loosing backward compatability. we have to make new one and make an alias to this.
| - (BOOL)shouldAutorotate | ||
| { | ||
| return YES; | ||
| if (self.maskVC == UIInterfaceOrientationPortrait){ |
There was a problem hiding this comment.
Please, put it this way, so it makes the style more readable. it's just about good code style
|
@moheny I added to comments, please, fix it or allow me to change this branch. ANd I will merge it soon! https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork |
| @@ -502,6 +503,7 @@ | |||
| ALWAYS_SEARCH_USER_PATHS = NO; | |||
| CLANG_ENABLE_OBJC_ARC = YES; | |||
| COPY_PHASE_STRIP = YES; | |||
| DEVELOPMENT_TEAM = ""; | |||
There was a problem hiding this comment.
Please, remove not related to this fix changes
| } else { | ||
| return YES; | ||
| } | ||
|
|
There was a problem hiding this comment.
more details about htis here:
https://wiki.c2.com/?ReturnBooleanEvaluations
This is a common idiom of just about every language, including Java.
Many programmers write methods that look like the following:
public boolean isBigger() {
// return if a is bigger than b
if (a > b)
return true;
else
return false;
}
The if statement is redundant. Boolean expressions (a > b) evaluate to a boolean value -- if your method needs to return it, then there's no need to have an if statement. The following code is equivalent to the previous:
public boolean isBigger () {
// return if a is bigger than b
return (a > b);
}
This fixes #398