-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #205 Add blur feature for picker background #251
Fixes #205 Add blur feature for picker background #251
Conversation
@nikola-mladenovic Yes, add please example to test and demonstrate it! Thank you! 👍 |
@skywinder - thanks, added one more static cell in Please note that there's a storyboard change for this static cell, just in case you have some work going on on that particular storyboard on some other branch. |
@skywinder - have you had a chance to look at this one? Any feedback perhaps? |
@nikola-mladenovic sorry for delay! Looks good! Can you also add a couple strings to readme about this feature, please? |
No worries - yes, will add them and update the PR 😊 |
For your information, in #205 I was thinking about an option to have a blur instead of the black transparent overlay, above the picker, not in the picker. So, it shouldn't close this issue, but still, that a nice feature you have here! |
@nikola-mladenovic Thank you for the PR! 👍 Already in |
Great news @skywinder - and yes, I'm going to try and add desc to readme by the end of this week! 😊 |
@tbaranes - I didn't get that from the desc in the issue; how about you create a new one for the that feature, and we'll create a new PR for that one? |
Sounds good @nikola-mladenovic, do you mind to take care of this? |
I can't build the example projects with the latest version of ASP 3.0 Undefined symbols for architecture x86_64: Which could be related to this commit. |
@masonk I don't see any issues yet. |
It's not that. I think it's related to the deployment target. When I build your example projects, only the ActionSheetPicker-iOS-5-7 project produces this linker error, the others don't. |
Added
pickerBlurRadius
property for setting the desired blur radius for picker background blur effect.It works only if
pickerBackgroundColor
is nil and the device is iPhone (iPad isn't currently supported due to issue with grabbing the snapshot image from UIPopoverController frame).@skywinder - if you agree I'd like to add an example to
ActionSheetPickerTableViewController
so it can be tried out easily?