Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #205 Add blur feature for picker background #251

Merged
merged 3 commits into from
May 19, 2016
Merged

Fixes #205 Add blur feature for picker background #251

merged 3 commits into from
May 19, 2016

Conversation

nikola-mladenovic
Copy link

Added pickerBlurRadius property for setting the desired blur radius for picker background blur effect.

It works only if pickerBackgroundColor is nil and the device is iPhone (iPad isn't currently supported due to issue with grabbing the snapshot image from UIPopoverController frame).

@skywinder - if you agree I'd like to add an example to ActionSheetPickerTableViewController so it can be tried out easily?

@skywinder
Copy link
Owner

@nikola-mladenovic Yes, add please example to test and demonstrate it! Thank you! 👍

@nikola-mladenovic
Copy link
Author

@skywinder - thanks, added one more static cell in ActionSheetPickerTableViewController which opens a picker with blur radius set to picker.pickerBlurRadius = @(10)

Please note that there's a storyboard change for this static cell, just in case you have some work going on on that particular storyboard on some other branch.

Blur Effect Sample

@nikola-mladenovic
Copy link
Author

@skywinder - have you had a chance to look at this one? Any feedback perhaps? ☺️

@skywinder
Copy link
Owner

skywinder commented May 5, 2016

@nikola-mladenovic sorry for delay! Looks good! Can you also add a couple strings to readme about this feature, please?

@nikola-mladenovic
Copy link
Author

No worries - yes, will add them and update the PR 😊

@tbaranes
Copy link

tbaranes commented May 19, 2016

For your information, in #205 I was thinking about an option to have a blur instead of the black transparent overlay, above the picker, not in the picker. So, it shouldn't close this issue, but still, that a nice feature you have here!

@skywinder skywinder merged commit b7576ce into skywinder:master May 19, 2016
@skywinder
Copy link
Owner

skywinder commented May 19, 2016

@nikola-mladenovic Thank you for the PR! 👍
If you can add some description to readme - it would be nice

Already in 2.1.0 🎉

@nikola-mladenovic
Copy link
Author

Great news @skywinder - and yes, I'm going to try and add desc to readme by the end of this week! 😊

@nikola-mladenovic
Copy link
Author

@tbaranes - I didn't get that from the desc in the issue; how about you create a new one for the that feature, and we'll create a new PR for that one?

@tbaranes
Copy link

Sounds good @nikola-mladenovic, do you mind to take care of this?

@masonk
Copy link

masonk commented Oct 30, 2016

I can't build the example projects with the latest version of ASP 3.0

Undefined symbols for architecture x86_64:
"OBJC_CLASS$_CIContext", referenced from:
objc-class-ref in AbstractActionSheetPicker.o
"OBJC_CLASS$_CIFilter", referenced from:
objc-class-ref in AbstractActionSheetPicker.o
"OBJC_CLASS$_CIImage", referenced from:
objc-class-ref in AbstractActionSheetPicker.o
"_kCIInputImageKey", referenced from:
-[AbstractActionSheetPicker blurPickerBackground] in AbstractActionSheetPicker.o
"_kCIInputRadiusKey", referenced from:
-[AbstractActionSheetPicker blurPickerBackground] in AbstractActionSheetPicker.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Which could be related to this commit.

@skywinder
Copy link
Owner

@masonk I don't see any issues yet.
that's could be a problem with some archs setups. try to clean your build.

@masonk
Copy link

masonk commented Nov 2, 2016

It's not that. I think it's related to the deployment target.

When I build your example projects, only the ActionSheetPicker-iOS-5-7 project produces this linker error, the others don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants