Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 5.1.1 compatibility added #164

Merged
merged 2 commits into from
Apr 17, 2015
Merged

Conversation

kashifhisam
Copy link

  • some minor fixes in order to be iOS5 compatible
  • autolayout removal in ActionSheetPicker-iOS6-7 storyboard
  • tested ActionSheetPicker-iOS6-7 on iPad 1st Gen with iOS5.1.1

- ActionSheetPicker-iOS6-7: autolayout removal in storyboard
- some minor fixes in order to be iOS5 compatible
@kashifhisam
Copy link
Author

My current iOS app is 5.1.1 compatible. Recently, I added some features in my app that uses your wonderful work. But later I found that it is for iOS 6+ only. I want my latest on-going update to be installable for my customers with iPad 1. So, I went on testing it on iPad1 and found some minor crashes which were easily fixable. I am submitting this commit believing that it might be useful for others.

@skywinder
Copy link
Owner

Wow! I didn't think that somebody still work with 5.x.x! 🎃
Thanks for contribution. I will review it soon! 👍

tapDismissAction other than TapActionNone will not work on old devices
@skywinder skywinder merged commit 4c83f91 into skywinder:master Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants