Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consumer proguard rules for sandwich module #220

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

skydoves
Copy link
Owner

Add consumer prguard rules for sandwich module.

@skydoves skydoves self-assigned this Nov 21, 2023
@skydoves skydoves changed the title Add consumer prguard rules for sandwich module Add consumer proguard rules for sandwich module Nov 21, 2023
@skydoves skydoves merged commit 1450395 into main Nov 21, 2023
@skydoves skydoves deleted the consumer.pro branch November 21, 2023 05:32
@teobaranga
Copy link

Hi @skydoves, would you be able to double check this please? I think the proguard file hasn't actually been included in the final aar, at least when looking at https://mvnrepository.com/artifact/com.github.skydoves/sandwich-android/2.0.3.

@skydoves
Copy link
Owner Author

Hey @teobaranga, is there any way to check if the package contains a proguard rule on the website that you provided? I just added some proguard rules explicitly, and it's available with 2.0.4-SNAPSHOT. I believe it should work well now.

@teobaranga
Copy link

There is, you should be able to see the proguard file inside the aar package available from maven. For example, the latest timber aar has a proguard.txt file in there https://mvnrepository.com/artifact/com.jakewharton.timber/timber/5.0.1. Thanks a lot for looking into this 👍

@skydoves
Copy link
Owner Author

Hey @teobaranga, I just checked the AAR file for the latest version of Sandwich, and as you mentioned, it doesn't contain proguard rules. I discovered that the proguard rules should be placed in the root folder of the KMM structure, and this will be addressed in the next release. Thanks a lot for bringing this to my attention! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants