Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Json instance configurable #8

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Conversation

rayworks
Copy link
Contributor

@rayworks rayworks commented Sep 1, 2022

Change

Make Json instance configurable when deserializing JSON data

Types of changes

What types of changes does your code introduce?

  • Enhancement (non-breaking change which adds functionality)

@rayworks rayworks requested a review from skydoves as a code owner September 1, 2022 05:59
@skydoves
Copy link
Owner

skydoves commented Sep 1, 2022

Hey @rayworks,
This totally looks really nice! Before merging this PR, could you please run the ./gradlew apiDump command line?
Thanks!

@rayworks
Copy link
Contributor Author

rayworks commented Sep 1, 2022

Hey @rayworks, This totally looks really nice! Before merging this PR, could you please run the ./gradlew apiDump command line? Thanks!

Hi @skydoves ,
Sorry for the broken compilation. Just updated the code.

Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally looks good to me!
Thank you for your contribution :)

@skydoves skydoves merged commit 8e6f5e6 into skydoves:main Sep 1, 2022
@rayworks rayworks deleted the json_config branch September 1, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants