Close bitmapReference and datasource safely

skydoves · Mar 10, 2023 · 386c8f4 · 386c8f4
1 parent ac47cbc
commit 386c8f4
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/fresco/src/main/kotlin/com/skydoves/landscapist/fresco/FlowBaseBitmapDataSubscriber.kt b/fresco/src/main/kotlin/com/skydoves/landscapist/fresco/FlowBaseBitmapDataSubscriber.kt
@@ -41,13 +41,15 @@ internal class FlowBaseBitmapDataSubscriber : BaseBitmapReferenceDataSubscriber(
       data = bitmapReference?.cloneOrNull(),
       dataSource = imageOrigin.toDataSource()
     )
+    CloseableReference.closeSafely(bitmapReference)
   }
 
   override fun onFailureImpl(dataSource: DataSource<CloseableReference<CloseableImage>>) {
     this.internalStateFlow.value = ImageLoadState.Failure(
-      data = dataSource,
+      data = dataSource.result?.cloneOrNull(),
       reason = dataSource.failureCause
     )
+    dataSource.close()
   }
 
   override fun onProgressUpdate(dataSource: DataSource<CloseableReference<CloseableImage>>) {