Update README.md #296
Merged
Update README.md #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skydoves
requested changes
Jan 1, 2022
README.md
Outdated
| @@ -525,8 +525,8 @@ balloon.clearAllPreferences() | |||
| ``` | |||
|
|
|||
| ### Avoid Memory leak | |||
| Dialog, PopupWindow and etc, have memory leak issue if not dismissed before activity or fragment are destroyed.<br> | |||
| But Lifecycles are now integrated with the Support Library since Architecture Components 1.0 Stable released.<br> | |||
| Dialog, PopupWindow and etc, canhave memory leak issue if not dismissed before the activity or fragment are destroyed.<br> | |||
There was a problem hiding this comment.
Suggested change
| Dialog, PopupWindow and etc, canhave memory leak issue if not dismissed before the activity or fragment are destroyed.<br> | |
| Dialog, PopupWindow and etc, can have memory leak issues if not dismissed before the activity or fragment is destroyed.<br> |
README.md
Outdated
| @@ -642,7 +642,7 @@ BalloonHighlightAnimation.ROTATE | |||
| .setBalloonHighlightAnimation(BalloonHighlightAnimation.SHAKE) | |||
| ``` | |||
|
|
|||
| We can implement the rotate animation like below the example: | |||
| We can implement rotate animation like the example below: | |||
There was a problem hiding this comment.
Suggested change
| We can implement rotate animation like the example below: | |
| We can implement rotate animation like the example below: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce?
Preparing a pull request for review
Ensure your change is properly formatted by running:
$ ./gradlew spotlessApplyPlease correct any failures before requesting a review.