Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top App Bar's Action Item Balloon Shows Inconsistent Color Fill-up On The Items. #298

Closed
itsnitish22 opened this issue Jan 1, 2022 · 6 comments
Assignees

Comments

@itsnitish22
Copy link
Contributor

Please complete the following information:

  • Library-Version: v1.4.1
  • Affected Device: Realme C1 with Android 9.0

Describe the Bug:

Top App Bar has an action item, on which when we click a balloon appears, showing 4 items in it. When we long tap on each item a color fills up showing the touch. But the color fillup is inconsistent in all the items. Refer the attached screenshots for more clarification.
Screenshot_2022-01-01-18-09-49-26_e721f2bb171a194dd4d07450abd1e101
Screenshot_2022-01-01-18-18-54-22_e721f2bb171a194dd4d07450abd1e101
Screenshot_2022-01-01-18-18-59-35_e721f2bb171a194dd4d07450abd1e101
Screenshot_2022-01-01-18-19-03-65_e721f2bb171a194dd4d07450abd1e101

Expected Behavior:

On a long tap of each item, the color fill-up must be consistent or the same.

@itsnitish22
Copy link
Contributor Author

I think this bug is a good first issue and I would like to work on it. It'll be great if I get some guidance.

@skydoves
Copy link
Owner

skydoves commented Jan 8, 2022

Hey @itsnitish22!
Sorry for my late response. Would you like to work on this? I'll assign this issue to you if you'd like to resolve this. 😄

@itsnitish22
Copy link
Contributor Author

Hi @skydoves
Yes, I would definitely like to work on this issue.
You can assign this to me :)

@itsnitish22
Copy link
Contributor Author

Hey @skydoves, I went through the code but wasn't able to find the function where it focuses on the item when it is tapped.
Could you please tell that exactly where can I find it.

@skydoves
Copy link
Owner

skydoves commented Jan 8, 2022

The android:background="?android:selectableItemBackground" implements ripple effect on the item.

@itsnitish22
Copy link
Contributor Author

@skydoves I have created a pull request. You can review it :)

skydoves pushed a commit that referenced this issue Jan 8, 2022
* updated gradle versions

* changes done in item_custom.xml

* required changes done

* added tab space on line 23 in build.gradle
@skydoves skydoves closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants