Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Q_fabs #128

Closed
wants to merge 1 commit into from
Closed

remove Q_fabs #128

wants to merge 1 commit into from

Conversation

sthalik
Copy link
Contributor

@sthalik sthalik commented Mar 26, 2018

Replace Q_fabs usages with fabsf. It's faster on today's hardware.

@sthalik
Copy link
Contributor Author

sthalik commented Mar 26, 2018

It's possible to replace incorrect sin to sinf as well as double-precision constants that cause promotion. But that's a lot of work for little gain.

I also noticed that -ffast-math causes the player to stick to some corners in geometry, there must be a numerical instability somewhere. It's much work to chase down where the denormal occurs.

skullernet
skullernet reviewed Mar 26, 2018
View reviewed changes
inc/shared/shared.h Outdated
@@ -27,6 +27,10 @@ with this program; if not, write to the Free Software Foundation, Inc.,
#include "config.h"
#endif

#ifdef _WIN32
# define _USE_MATH_DEFINES
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed with MinGW-w64 5.0.3 unless__STRICT_ANSI__ is defined.

@sthalik
Copy link
Contributor Author

sthalik commented Mar 26, 2018

Changed.

@skullernet
Copy link
Owner

Applied, thanks.

@skullernet skullernet closed this Mar 26, 2018
@sthalik sthalik deleted the pr-math branch March 27, 2018 07:48
Iceman12k pushed a commit to Iceman12k/q2pro that referenced this pull request Feb 8, 2024
@darkshade9
Merge pull request skullernet#128 from actionquake/hotfix-1
f2d0f82 
Hotfix 1
res2k added a commit to res2k/q2pro that referenced this pull request Nov 22, 2024
@res2k
Need to explicitly enable vp3_decoder for ffmpeg now. Fixes skullerne…
b7ba7d3 
…t#128
res2k added a commit to res2k/q2pro that referenced this pull request Nov 22, 2024
@res2k
Need to explicitly enable vp3_decoder for ffmpeg now. Fixes skullerne…
375b3f4 
…t#128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullernet skullernet skullernet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sthalik @skullernet