Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport https://github.com/skip-mev/connect/pull/757 #855

Merged
merged 10 commits into from
Dec 12, 2024
Merged

chore: backport https://github.com/skip-mev/connect/pull/757 #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7f7d1fe
fix: error handling for invalid gRPC endpoints (#757)
technicallyty Sep 18, 2024
bc3a350
Merge branch 'release/v1.x.x' into chore/backport-757
aljo242 Dec 10, 2024
c792307
Merge branch 'release/v1.x.x' into chore/backport-757
aljo242 Dec 10, 2024
1a77ce9
Merge branch 'release/v1.x.x' into chore/backport-757
aljo242 Dec 11, 2024
138029f
Merge branch 'release/v1.x.x' into chore/backport-757
aljo242 Dec 11, 2024
d719ea9
Merge branch 'release/v1.x.x' into chore/backport-757
aljo242 Dec 11, 2024
eca2ea6
Merge branch 'release/v1.x.x' into chore/backport-757
aljo242 Dec 11, 2024
3db6423
Merge branch 'release/v1.x.x' into chore/backport-757
aljo242 Dec 11, 2024
0acf522
Merge branch 'release/v1.x.x' into chore/backport-757
aljo242 Dec 12, 2024
309692d
Merge branch 'release/v1.x.x' into chore/backport-757
aljo242 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/slinky/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"errors"
"fmt"
"net/http"

//nolint: gosec
_ "net/http/pprof"
"os"
Expand Down
8 changes: 4 additions & 4 deletions providers/factories/oracle/marketmap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,19 +49,19 @@
return nil, err
}

switch name := cfg.Name; {
case name == dydx.Name:
switch cfg.Name {
case dydx.Name:
apiDataHandler, err = dydx.NewAPIHandler(logger, cfg.API)
ids = []types.Chain{{ChainID: dydx.ChainID}}
case name == dydx.SwitchOverAPIHandlerName:
case dydx.SwitchOverAPIHandlerName:

Check warning on line 56 in providers/factories/oracle/marketmap.go

View check run for this annotation

Codecov / codecov/patch

providers/factories/oracle/marketmap.go#L56 

Added line #L56 was not covered by tests
marketMapFetcher, err = dydx.NewDefaultSwitchOverMarketMapFetcher(
logger,
cfg.API,
requestHandler,
apiMetrics,
)
ids = []types.Chain{{ChainID: dydx.ChainID}}
case name == dydx.ResearchAPIHandlerName || name == dydx.ResearchCMCAPIHandlerName:
case dydx.ResearchAPIHandlerName, dydx.ResearchCMCAPIHandlerName:

Check warning on line 64 in providers/factories/oracle/marketmap.go

View check run for this annotation

Codecov / codecov/patch

providers/factories/oracle/marketmap.go#L64 

Added line #L64 was not covered by tests
marketMapFetcher, err = dydx.DefaultDYDXResearchMarketMapFetcher(
requestHandler,
apiMetrics,
Expand Down
Loading