Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: block height staleness checker #705

Merged
merged 15 commits into from
Aug 27, 2024
Merged

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Aug 26, 2024

Closes CON-1704

Add a BlockAgeChecker interface that defi providers can use when checking responses.

@aljo242 aljo242 changed the title feat/block height staleness feat: block height staleness checker Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 83.56164% with 12 lines in your changes missing coverage. Please review.

Project coverage is 56.53%. Comparing base (0ea032f) to head (08fc79d).
Report is 1 commits behind head on main.

Files Patch % Lines
providers/apis/defi/ethmulticlient/multi_client.go 72.41% 7 Missing and 1 partial ⚠️
providers/apis/defi/osmosis/client.go 85.71% 1 Missing and 1 partial ⚠️
providers/apis/defi/raydium/multi_client.go 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #705      +/-   ##
==========================================
+ Coverage   56.50%   56.53%   +0.03%     
==========================================
  Files         256      257       +1     
  Lines       13461    13495      +34     
==========================================
+ Hits         7606     7630      +24     
- Misses       5121     5128       +7     
- Partials      734      737       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some code that can be removed leftover

providers/apis/defi/ethmulticlient/multi_client.go Outdated Show resolved Hide resolved
@aljo242 aljo242 merged commit 718179f into main Aug 27, 2024
18 checks passed
@aljo242 aljo242 deleted the feat/block-height-staleness branch August 27, 2024 13:09
aljo242 pushed a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants