Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment explaining need for drain_lock #102

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Update comment explaining need for drain_lock #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/aiokatcp/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,8 @@ def write_message(self, msg: core.Message) -> None:

async def drain(self) -> None:
"""Block until the outgoing write buffer is small enough."""
# The Python 3.5 implementation of StreamWriter.drain is not reentrant,
# so we use a lock.
# StreamWriter.drain is not reentrant prior to Python 3.10.8, so we use
# a lock (https://github.com/python/cpython/issues/74116).
async with self._drain_lock:
if not self._writer_closing:
try:
Expand Down
Loading