Also report transfer and content size per offending URL (#81)

sitespeedio · Nov 25, 2021 · 61e724b · 61e724b
1 parent 01092ea
commit 61e724b
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 4 deletions.
diff --git a/lib/har/performance/compressAssets.js b/lib/har/performance/compressAssets.js
@@ -36,7 +36,11 @@ module.exports = {
       let myScore = processAsset(asset);
       if (myScore > 0) {
         score -= myScore;
-        offending.push(asset.url);
+        offending.push({
+          url: asset.url,
+          transferSize: asset.transferSize,
+          contentSize: asset.contentSize
+        });
       }
     });
 

diff --git a/lib/har/performance/cssSize.js b/lib/har/performance/cssSize.js
@@ -18,10 +18,16 @@ module.exports = {
     let contentLimit = 400000;
     let score = 100;
     let advice = '';
+    const offending = [];
 
     cssAssets.forEach(function (asset) {
       transferSize += asset.transferSize;
       contentSize += asset.contentSize;
+      offending.push({
+        url: asset.url,
+        transferSize: asset.transferSize,
+        contentSize: asset.contentSize
+      });
     });
 
     if (transferSize > transferLimit) {
@@ -54,7 +60,7 @@ module.exports = {
 
     return {
       score,
-      offending: [],
+      offending: offending,
       advice
     };
   }

diff --git a/lib/har/performance/javascriptSize.js b/lib/har/performance/javascriptSize.js
@@ -22,7 +22,11 @@ module.exports = {
     jsAssets.forEach(function (asset) {
       transferSize += asset.transferSize;
       contentSize += asset.contentSize;
-      offending.push(asset.url);
+      offending.push({
+        url: asset.url,
+        transferSize: asset.transferSize,
+        contentSize: asset.contentSize
+      });
     });
 
     if (transferSize > transferLimit) {

diff --git a/lib/har/performance/optimalCssSize.js b/lib/har/performance/optimalCssSize.js
@@ -20,7 +20,11 @@ module.exports = {
     cssAssets.forEach(function (asset) {
       if (asset.transferSize > transferLimit) {
         score -= 10;
-        offending.push(asset.url);
+        offending.push({
+          url: asset.url,
+          transferSize: asset.transferSize,
+          contentSize: asset.contentSize
+        });
         advice +=
           asset.url +
           ' size is ' +