Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obtain xml import url path without query param #402

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

bpierce-gaig
Copy link
Contributor

Fixed problem evaluating WSDL files with xml imports containing relative URLs with query params. Code was incorrectly returning full uri rather than just the path and subsequently adding the path a second time. This resulted in the import not being found.

Fixed problem evaluating WSDL files with xml imports containing relative URLs with query params. Code was incorrectly returning full uri rather than just the path and subsequently adding the path a second time. This resulted in the import not being found.
@brunato
Copy link
Member

brunato commented Apr 25, 2024

Thank you for the contribute, I merge this despite the error.

Unfortunately this seems to be more complicated because the URL can be encoded or not, so I will add other fixes in location module.

@brunato brunato merged commit 141bf5e into sissaschool:master Apr 25, 2024
0 of 17 checks passed
@brunato
Copy link
Member

brunato commented Apr 28, 2024

I've done a new bugfix release (v3.3.1) after the merge. The result is a more clear LocationPath code in from_uri() and as_uri() methods and a normalize_url() that encode the URL in any case using a new helper function.

It should still works with the import of xml in your WSDL files.

@bpierce-gaig
Copy link
Contributor Author

Tested and it looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants