Add track number and artist to AlbumInfoScreen #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siper
requested changes
Jan 6, 2025
feature/album/info/src/main/java/ru/stersh/youamp/feature/album/domain/AlbumInfo.kt
Outdated
Show resolved
Hide resolved
feature/album/info/src/main/java/ru/stersh/youamp/feature/album/ui/AlbumInfoScreen.kt
Outdated
Show resolved
Hide resolved
feature/album/info/src/main/java/ru/stersh/youamp/feature/album/ui/AlbumInfoScreen.kt
Outdated
Show resolved
Hide resolved
|
Hi, thanks for the comments. The first to were Ktlint messing with some files that I was poking around in, sorry about that! I reverted those and made the other adjustments, hope it's ok now. |
siper
reviewed
Jan 6, 2025
feature/album/info/src/main/java/ru/stersh/youamp/feature/album/ui/AlbumInfoScreen.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information on the album tracklist view is currently somewhat lacking. For albums by single artists, it is not such a big problem, but on compilation albums I think seeing the artist of the individual tracks adds value. I have made a few tweaks to the UI to show the artist per track and also the track number, all this information was being pulled in the background already anyway.
Before:
After:
Please let me know if I should create an issue for this first!