Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go vet errors #473

Closed
ncopa opened this issue Jun 7, 2021 · 1 comment
Closed

go vet errors #473

ncopa opened this issue Jun 7, 2021 · 1 comment

Comments

@ncopa
Copy link
Contributor

ncopa commented Jun 7, 2021

When I run make test in git master I get the following errors:

$ go version
go version go1.16.5 linux/amd64
$ make test
go vet github.com/sipcapture/heplify-server/cmd/heplify-server github.com/sipcapture/heplify-server/database github.com/sipcapture/heplify-server/decoder github.com/sipcapture/heplify-server/decoder/luar github.com/sipcapture/heplify-server/remotelog github.com/sipcapture/heplify-server/remotelog/logproto github.com/sipcapture/heplify-server/rotator github.com/sipcapture/heplify-server/server github.com/sipcapture/heplify-server/sipparser
# github.com/sipcapture/heplify-server/rotator
rotator/rotator.go:222:2: unreachable code
# github.com/sipcapture/heplify-server/decoder
decoder/decoder.go:299:35: possible misuse of reflect.SliceHeader
make: *** [Makefile:13: test] Error 2
ncopa added a commit to ncopa/heplify-server that referenced this issue Jun 7, 2021
Fixes go vet errors:

    # github.com/sipcapture/heplify-server/rotator
    rotator/rotator.go:222:2: unreachable code
    # github.com/sipcapture/heplify-server/decoder
    decoder/decoder.go:299:35: possible misuse of reflect.SliceHeader

see golang/go#40701
adubovikov added a commit that referenced this issue Jun 7, 2021
@ncopa
Copy link
Contributor Author

ncopa commented Jun 7, 2021

fixed in #474

@ncopa ncopa closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant