Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing default dom element getter and single-spa props. #6

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Implementing default dom element getter and single-spa props. #6

merged 1 commit into from
Mar 2, 2020

Conversation

joeldenning
Copy link
Member

@joeldenning joeldenning commented Mar 1, 2020 •
edited
Loading

  1. Pass single-spa props to svelte component
  2. Upgrade to latest svelte API (props instead of data)
  3. Use prettier
  4. Implement default domElementGetter

Resolves #5

@joeldenning joeldenning mentioned this pull request Mar 1, 2020
Closed
joeldenning
joeldenning commented Mar 2, 2020
View reviewed changes
src/single-spa-svelte.js
target: opts.domElementGetter(),
data: opts.data || {},
target: domElement,
props: Object.assign({}, singleSpaProps, opts.props)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to latest svelte docs, data should be passed in as props, not data (I think). See https://svelte.dev/docs#Client-side_component_API

Due to this change, I plan on releasing this PR as a new major version

@TheMcMurder TheMcMurder self-assigned this Mar 2, 2020
TheMcMurder
TheMcMurder approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@TheMcMurder TheMcMurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐙

@joeldenning joeldenning merged commit cd7f938 into master Mar 2, 2020
@joeldenning joeldenning deleted the props-dom-element branch March 2, 2020 18:58
@joeldenning joeldenning mentioned this pull request Mar 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMcMurder TheMcMurder TheMcMurder approved these changes

Assignees

@TheMcMurder TheMcMurder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is this active?
2 participants
@joeldenning @TheMcMurder