Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add update lifecycle method #10

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Add update lifecycle method #10

merged 3 commits into from
Oct 9, 2020

Conversation

gcaven
Copy link
Contributor

@gcaven gcaven commented Oct 7, 2020

  1. Add update lifecycle method, which which uses the svelte component API ($set) to update root component props
  2. Update test to include update lifecycle method

joeldenning
joeldenning approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@joeldenning joeldenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is an important feature for parcels. If you have interest in helping further, I'd love to see a svelte-specific parcel wrapper component, to make using parcels easier.

@joeldenning joeldenning merged commit 3f0569d into single-spa:master Oct 9, 2020
@joeldenning
Copy link
Member

Published in https://github.com/single-spa/single-spa-svelte/releases/tag/v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeldenning joeldenning joeldenning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gcaven @joeldenning @gcaven-nbx