Skip to content

Commit

Permalink
Support for entry files with extension other than .js. Resolves #305 (#…
Browse files Browse the repository at this point in the history
…306)

* Support for entry files with extension other than .js. Resolves #305

* Fix
  • Loading branch information
joeldenning authored Jul 7, 2021
1 parent 72f26a8 commit a380ce4
Show file tree
Hide file tree
Showing 4 changed files with 130 additions and 203 deletions.
5 changes: 5 additions & 0 deletions .changeset/many-flies-tan.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"webpack-config-single-spa": minor
---

Support for entry files with non .js extensions
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Note that create-single-spa can run in the current directory by default, but you
This project uses [changesets](https://github.com/atlassian/changesets) to manage versioning of each of the packages. Before you create a pull request, run the following:

```sh
pnpx changeset
pnpm exec changeset
```

## Tests
Expand All @@ -32,7 +32,7 @@ If you're having trouble diagnosing why a test is failing, try running the tests
To publish to npm, run the following commands:

```sh
GITHUB_TOKEN=... pnpx changeset version
GITHUB_TOKEN=... pnpm exec changeset version
git add .
git commit -m "NPM Publish"
pnpm publish -r
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ function webpackConfigSingleSpa(opts) {
mode: isProduction ? "production" : "development",
entry: path.resolve(
process.cwd(),
`src/${opts.orgName}-${opts.projectName}.js`
`src/${opts.orgName}-${opts.projectName}`
),
output: {
filename: `${opts.orgName}-${opts.projectName}.js`,
Expand Down
Loading

0 comments on commit a380ce4

Please sign in to comment.