Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/C++] Release GIL in IntIndexer C++ code #3344

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

bkmartinjr
Copy link
Member

@bkmartinjr bkmartinjr commented Nov 19, 2024

The Python IntIndexer bindings fail to release the GIL. These are long-running entry points and should release it.

II've benchmarked on some threaded code, and found that this change improves concurrency.

Context: #3345 [sc-57301] [sc-59595]

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.76%. Comparing base (67213c9) to head (8ad0260).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3344      +/-   ##
==========================================
+ Coverage   85.66%   85.76%   +0.09%     
==========================================
  Files          57       57              
  Lines        6180     6180              
==========================================
+ Hits         5294     5300       +6     
+ Misses        886      880       -6     
Flag Coverage Δ
python 85.76% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.76% <ø> (+0.09%) ⬆️
libtiledbsoma ∅ <ø> (∅)
---- 🚨 Try these New Features:

@bkmartinjr bkmartinjr marked this pull request as ready for review November 19, 2024 22:57
@johnkerl johnkerl changed the title [python/C++] release GIL in IntIndexer C++ code [python/C++] Release GIL in IntIndexer C++ code Nov 19, 2024
@bkmartinjr bkmartinjr merged commit 34793eb into main Nov 20, 2024
21 checks passed
@bkmartinjr bkmartinjr deleted the bkmartinjr/reindexer-release-gil branch November 20, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants