Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Add parameters to ExperimentAxis query methods #1553

Merged
merged 3 commits into from
Aug 1, 2023
Merged

[python] Add parameters to ExperimentAxis query methods #1553

merged 3 commits into from
Aug 1, 2023

Conversation

ebezzi
Copy link
Member

@ebezzi ebezzi commented Jul 26, 2023 •
edited
Loading

Resolves #1527, together with single-cell-data/SOMA#169. Requires a somacore release for this to work.

This PR only has tests.

@ebezzi ebezzi changed the title Add parameters to ExperimentAxis query methods [python] Add parameters to ExperimentAxis query methods Jul 26, 2023
@ebezzi ebezzi marked this pull request as draft July 26, 2023 20:11
@ebezzi ebezzi changed the title [python] Add parameters to ExperimentAxis query methods [WIP] [python] Add parameters to ExperimentAxis query methods Jul 26, 2023
@johnkerl johnkerl changed the title [WIP] [python] Add parameters to ExperimentAxis query methods [WIP] [python] Add parameters to ExperimentAxis query methods Jul 26, 2023
bkmartinjr
bkmartinjr approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preemptive approval based upon review of the sister PR.

@johnkerl
Copy link
Member

johnkerl commented Jul 31, 2023 •
edited
Loading

Note the latest commit here was branch off main from April -- I just did a merge commit to bring this up to date with today's main

@johnkerl
Copy link
Member

I also pushed a commit to depend on somacore 1.0.4 which now exists

johnkerl added a commit that referenced this pull request Jul 31, 2023
@johnkerl
Put somacore 1.0.4 on #1553
657ef40
@ebezzi ebezzi marked this pull request as ready for review August 1, 2023 18:02
@johnkerl johnkerl changed the title [WIP] [python] Add parameters to ExperimentAxis query methods [python] Add parameters to ExperimentAxis query methods Aug 1, 2023
@johnkerl johnkerl merged commit 5729480 into main Aug 1, 2023
@johnkerl johnkerl deleted the ebezzi/add-parameters-to-experimentaxis-query branch August 1, 2023 18:11
johnkerl added a commit that referenced this pull request Aug 2, 2023
@johnkerl
Put somacore 1.0.4 on #1553
862af17
johnkerl added a commit that referenced this pull request Aug 2, 2023
@johnkerl
[c++, python, r] Update to core 2.16.1, tiledb-py 0.22.1, tiledb-r 0.…
a103172 
…20.2 (#1561)

* Update to core 2.16.1, tiledb-py 0.22.1, tiledb-r 0.20.2, and somacore 1.0.4

* Put somacore 1.0.4 on #1553

* apis/r/NEWS.md

* split out R-versioning mods to another PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnkerl johnkerl johnkerl approved these changes

@bkmartinjr bkmartinjr bkmartinjr approved these changes

@pablo-gar pablo-gar Awaiting requested review from pablo-gar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] ExperimentAxisQuery read methods should expose batch_size and result_order params
3 participants
@ebezzi @johnkerl @bkmartinjr