fix breaking performance change in set-required #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use distributive conditional to expand union types as alternative fix for sindresorhus@9c12497 - but alleviating chance of producing TS error TS2589: 'Type instantiation is excessively deep and possibly infinite'
andyjy
commented
May 29, 2023
Comment on lines
+30
to
+33
| // `extends unknown` is always going to be the case and is used to convert any | ||
| // union into a [distributive conditional | ||
| // type](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#distributive-conditional-types). | ||
| BaseType extends unknown |
There was a problem hiding this comment.
This use of a distributive conditional achieves the original goal of #611 in a more performant way
andyjy
commented
May 29, 2023
Comment on lines
+35
to
+36
| // Pick just the keys that are optional from the base type. | ||
| Except<BaseType, Keys> & |
There was a problem hiding this comment.
This part reinstates the original code prior to #611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates #611 with a better fix that uses a distributive conditional to expand union types.
The original fix released in
v3.10.0is less efficient, producing TS errorTS2589: 'Type instantiation is excessively deep and possibly infinite'when applied to my application code (as a result of computing all the intersections of each key inKeyswith it'sRequired<>version).Fixes #627