Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sindre,
Hereby a PR, the characters are correct and checked by an Armenian. The only thing is that sometimes in a way the replaced characters get switched around. I can't really figure out why.
example:
When I slugify:
Ե ր ե ւ ա ն
It compiles to:
re ye v a n
, where it should beye re v a n
.Hope this can be a good addition to the package. So far it works for me with the current replacements as custom replacements, although they arent completely correct, the slugs atleast look "quite ok".
The test in this version passes, but
Should actually be:
Thanks!