Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Armenian characters #29

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Conversation

silvandiepen
Copy link
Contributor

@silvandiepen silvandiepen commented Apr 23, 2019

Hi Sindre,

Hereby a PR, the characters are correct and checked by an Armenian. The only thing is that sometimes in a way the replaced characters get switched around. I can't really figure out why.

example:
When I slugify: Ե ր ե ւ ա ն
It compiles to: re ye v a n, where it should be ye re v a n.

Hope this can be a good addition to the package. So far it works for me with the current replacements as custom replacements, although they arent completely correct, the slugs atleast look "quite ok".

The test in this version passes, but

	t.is(slugify('Ե ր ե ւ ա ն', {lowercase: false, separator: ' '}), 're ye v a n');

Should actually be:

	t.is(slugify('Ե ր ե ւ ա ն', {lowercase: false, separator: ' '}), 'ye re v a n');

Thanks!

@sindresorhus
Copy link
Owner

The only thing is that sometimes in a way the replaced characters get switched around. I can't really figure out why.

Can you open an issue about that?

@sindresorhus sindresorhus changed the title Added Armenian characters Add Armenian characters Jan 21, 2020
@sindresorhus sindresorhus merged commit 5220d93 into sindresorhus:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants