Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $ sign url escaping in WSL 2 #203

Closed
wants to merge 2 commits into from

Conversation

CryogenicPlanet
Copy link

Closes #202

@tim-stasse
Copy link
Contributor

Did you read the comment on line 100?

@CryogenicPlanet
Copy link
Author

My bad I completely missed that @tim-stasse, how would you recommend fixing #202. I wasn't able to think of a good way to escape the $ sign, for it to work in wsl the cli should get it escaped as \$ but javascript was automatically changing that to $ for me

@An6r
Copy link

An6r commented Nov 24, 2020

Does anyone have news about this one?

@sindresorhus
Copy link
Owner

@CryogenicPlanet Still interested in trying to fix this?

@CryogenicPlanet
Copy link
Author

Hey @sindresorhus, sorry won't be able to work on this anymore. Had some other issues with WSL and now moved to linux proper so don't have WSL on hand to test a solution, even if I came up with one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL with $ does not work on WSL 2
4 participants